Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Julia version restriction #147

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Update Julia version restriction #147

merged 1 commit into from
Feb 12, 2024

Conversation

calvinp0
Copy link
Member

@calvinp0 calvinp0 commented Feb 9, 2024

Julia needs a version restriction. This has not been updated in the RMG-Py environment.yml file, so we need to patch it this way

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (2de3b76) 73.46% compared to head (4352c8e) 74.91%.
Report is 91 commits behind head on main.

Files Patch % Lines
t3/utils/flux.py 81.42% 52 Missing and 13 partials ⚠️
t3/utils/fix_cantera.py 90.66% 3 Missing and 4 partials ⚠️
t3/simulate/rmg_constantTP.py 0.00% 5 Missing ⚠️
t3/imports.py 40.00% 3 Missing ⚠️
t3/runners/rmg_runner.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   73.46%   74.91%   +1.44%     
==========================================
  Files          22       24       +2     
  Lines        2891     3317     +426     
  Branches      762      853      +91     
==========================================
+ Hits         2124     2485     +361     
- Misses        552      601      +49     
- Partials      215      231      +16     
Flag Coverage Δ
unittests 74.91% <81.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@calvinp0 calvinp0 merged commit 4d3484e into main Feb 12, 2024
6 checks passed
@calvinp0 calvinp0 deleted the ci_julia_fix branch February 12, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants