Added cleaning steps #135
Merged
Added cleaning steps #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongd
reviewed
Oct 27, 2023
| @@ -117,6 +117,7 @@ jobs: | |||
| - name: Cythonize RMG-Py | |||
| run: | | |||
| cd RMG-Py | |||
| conda activate rmg_env | |||
There was a problem hiding this comment.
this line was removed in another commit and added here. Can you squash the two commits?
tempfile
Outdated
| @@ -0,0 +1,2 @@ | |||
| . | |||
Improved the CI for T3 to now ensure that the base OS used on GitHub has ample space for the installation and testing of T3. Additionally, we activate the clean command in RMG-Py to ensure that all files are not cythonised prior to cythonising. Finally, installation of Julia and the connection to Python and vice versa has been adjusted.
T3 Main tests were failing due to changes in RMG-Py. This has been rectified. The first change is now we look for the numeric identifier of the species instead of the species name as the numeric identifier should never change and is unique. The second function change is that the chemical reaction string uses '<=>' instead of '='.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.