Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frag branch #12

Closed
wants to merge 37 commits into from
Closed

Frag branch #12

wants to merge 37 commits into from

Conversation

lily90502
Copy link

To plot flux diagrams for fragment models

@xiaoruiDong
Add parametrized P domain
913820e
@xiaoruiDong
Add constant P domain
bb3eb49
@xiaoruiDong
Add calcthermo for constant P domain
db1d74a
@xiaoruiDong
Add calcthermo for parametrized P domain
1911aea
@xiaoruiDong
Add calcthermoderiv. for constant P domain
b78a444
@xiaoruiDong
Add calcthermoderiv. for parametrized P domain
d7a3ad3
@xiaoruiDong
Add new parameter to calcthermoderiv.
bc98a27
@xiaoruiDong
Fix error when readinput without species dict.
49be12a
@xiaoruiDong
Add constrain P domain to support flux diagram.
e053383
@xiaoruiDong
Add requirement for flux diagram plotting
097b147
@xiaoruiDong
Avoid plot inertial gases in molefraction plot.
f707843
@xiaoruiDong
Add iJulia for ConstantP reactor.
22140b9
@xiaoruiDong
Add missing dependency of fluxdiagram plotting and CSV/DataFrame depe…
2bb25e7 
…ndency for output
@xiaoruiDong
Add Printf to allow better time display in flux diagram
12cb66d
@xiaoruiDong
Enable assigning output type and species fig saving directory
abd3a1d
@xiaoruiDong
Fix typo in yml.jl
ae69505
@xiaoruiDong
Enable calculate rate with only one pair of kf and krev given
4f97dfd
@xiaoruiDong
Enable getkfkrevs of reactions from a list of rxn indice
a956871
@xiaoruiDong
Add a pseudo-calcthermo function to obtain kfs and krevs for ROP anal…
cc1e57a 
…ysis
@xiaoruiDong
Add new rops() to calc rops time profile for all reactions w.r.t one …
92e03ad 
…species
@xiaoruiDong
Make minor time-saving improvement for rops()
93e789a
@xiaoruiDong
Avoid generating species fig for species not used in flux diagram
ccbceb7
@xiaoruiDong
Enable CSV output for concentrations and rops
98dfaa0
@xiaoruiDong
Fixup ROP result output and minor speed up.
f714b6b
@xiaoruiDong
Combine getkfkrevs and getropkfkrevs
ea34ed2
@xiaoruiDong
BugFix: using abspath to avoid unexpected loading problem
60a4a11
@xiaoruiDong
BugFix: Calcthermo for constantP reactor
38fcb0b
@xiaoruiDong
Clean up the unit test for Reactor
ca71f9f
@xiaoruiDong
Clean up the unit test for Tools
63f0ed4
@xiaoruiDong
Clean up the unit test for Thermo
2d6694e
@mjohnson541
Copy link
Collaborator

Can you separate the non-fragment changes from the rest of the PR?

@hwpang
Copy link
Contributor

hwpang commented Nov 14, 2023

I think this is either already merged in (Xiaorui's parts) or covered by PRs #216 and #239 (Yen-Ting's parts), so I'm closing this

@hwpang hwpang closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lily90502 @mjohnson541 @hwpang @xiaoruiDong