-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lithium rebase #667
Open
ssun30
wants to merge
107
commits into
main
Choose a base branch
from
lithium_rebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lithium rebase #667
+73,620
−14,447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since desorbed mols are liquid phase, change in entropy with adsorption to surface should be less
This reverts commit 98f52fc.
Abraham and Mintz parameters fitted using COSMO-RS data and solute parameter database viscosity parameters taken from DEC
Surface Carbonate CO 2F Decomposition is left out because it results in 4 products which RMG currently cannot handle
… carbonate compounds properties for the mixture are estimates
the old reactions were for an electronic state where the reaction was not barrierless
here we move to a higher up rule in the tree to estimate this particular reaction
based on Pynta calculations with a simple reaction error cancellation scheme
based on Pynta calculations
This is to make them consistent with Li families
@mjohnson541 I realized that certain unit tests, such as Currently these discrepancies affect this commit where the test values for Petersson and Melius type BACs were changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to replace PR #605 . PR #648 introduced a lot of AEC and BAC values that conflict with those introduced in the original
lithium
branch. As a result, rebasing it onto the latestmain
could be a chore. I have separatedlithium
branch into two parts:This branch, which includes all the changes necessary to make the echem-rebase branch of RMG-Py function properly.
Another branch that contains all the AECs, BACs, and new reference sets. It has not been rebased onto the latest main yet due to the large amount of conflicts.
I have created a backup branch that contains all the commits in
lithium
, but with commits involving quantum data moved to the end.This PR also includes several new commits necessary to make CO2 reduction models.
The intention is to merge both this branch and the
echem-rebase
branch so we can get a minimum viable product that can do Li and CO2RR model generation.