Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused testing files, use reusable workflow for CI #625

Closed
wants to merge 6 commits into from

Conversation

JacksonBurns
Copy link
Contributor

see https://github.blog/2022-02-10-using-reusable-workflows-github-actions/ this change will use the regression testing action in place on RMG-Py to run all the regression tests here as well. Waiting on ReactionMechanismGenerator/RMG-Py#2472 to be merged before restarting the tests here to make sure they work.

@JacksonBurns JacksonBurns marked this pull request as draft June 20, 2023 03:06
@JacksonBurns
Copy link
Contributor Author

Currently failing because the action on RMG-Py uses checkout on RMG-Py and tries to build the environment file over here without having it.

Action should clone RMG-Py if it is running on RMG-database (without disrupting the current setup), and expose the same rmg_Database_branch equivalent for rmg-py.

@JacksonBurns
Copy link
Contributor Author

This run will fail, and then it should be retriggered after RMG-Py#2494 is merged (ReactionMechanismGenerator/RMG-Py#2494)

@JacksonBurns

This comment was marked as outdated.

@JacksonBurns
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant