Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halogen kinetics update #549

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Halogen kinetics update #549

wants to merge 17 commits into from

Conversation

davidfarinajr
Copy link
Contributor

@davidfarinajr davidfarinajr commented Nov 20, 2021

This PR adds some training reactions, regenerates trees, revises some A factors for rate rules, adds some forbidden groups, adds a new halocarbene_CO_dimerization family, and adds training + regenerate tree for 1,3_sigmatropic_rearrangement

@davidfarinajr
Copy link
Contributor Author

I calculated some training reactions for 1,3_sigmatropic_rearrangement involving a halogen shift and a hydride (bonded to a halogen-bonded carbon) shift (1f15776) , and then regenerated the tree. I constructed the top of the tree by hand here 4bb10e6, the used auto tree gen script to generate extensions. We could make separate 1,3_hydride and 1,3_halogen shift families, put placing the nodes at the top of the tree essentially accomplishes this with the one family.

We are currently overestimating the rates of these types of reactions.

https://rmg.mit.edu/database/kinetics/families/1,3_sigmatropic_rearrangement/rate_rules/reactant1=1%20F%20u0%20p3%20c0%20%7B5,S%7D%0A2%20F%20u0%20p3%20c0%20%7B5,S%7D%0A3%20F%20u0%20p3%20c0%20%7B5,S%7D%0A4%20F%20u0%20p3%20c0%20%7B6,S%7D%0A5%20C%20u0%20p0%20c0%20%7B1,S%7D%20%7B2,S%7D%20%7B3,S%7D%20%7B6,S%7D%0A6%20C%20u0%20p0%20c0%20%7B4,S%7D%20%7B5,S%7D%20%7B7,D%7D%0A7%20C%20u0%20p0%20c0%20%7B6,D%7D%20%7B8,S%7D%20%7B9,S%7D%0A8%20H%20u0%20p0%20c0%20%7B7,S%7D%0A9%20H%20u0%20p0%20c0%20%7B7,S%7D%0A__product1=1%20F%20u0%20p3%20c0%20%7B5,S%7D%0A2%20F%20u0%20p3%20c0%20%7B6,S%7D%0A3%20F%20u0%20p3%20c0%20%7B7,S%7D%0A4%20F%20u0%20p3%20c0%20%7B7,S%7D%0A5%20C%20u0%20p0%20c0%20%7B1,S%7D%20%7B6,S%7D%20%7B8,S%7D%20%7B9,S%7D%0A6%20C%20u0%20p0%20c0%20%7B2,S%7D%20%7B5,S%7D%20%7B7,D%7D%0A7%20C%20u0%20p0%20c0%20%7B3,S%7D%20%7B4,S%7D%20%7B6,D%7D%0A8%20H%20u0%20p0%20c0%20%7B5,S%7D%0A9%20H%20u0%20p0%20c0%20%7B5,S%7D%0A__res=True

Here is the cross validation results for the tree:

tree_cross_val.pdf
tree_cross_validation.csv

@davidfarinajr davidfarinajr force-pushed the halogen_kinetics_update branch 2 times, most recently from fb6ff2a to dcb0960 Compare December 3, 2021 21:56
@davidfarinajr davidfarinajr force-pushed the halogen_kinetics_update branch 3 times, most recently from 509a6d7 to b579a32 Compare December 14, 2021 22:32
@rwest rwest requested a review from Nora-Khalil March 8, 2024 16:25
@rwest
Copy link
Member

rwest commented Mar 8, 2024

@Nora-Khalil what's the status of all David's old PRs for halocarbons? Please can we figure out which to rebase / merge / abandon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants