Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Cathub kinetics #499

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

WIP - Cathub kinetics #499

wants to merge 11 commits into from

Conversation

davidfarinajr
Copy link
Contributor

This is a WIP PR to add kinetic data from cat hub (https://www.catalysis-hub.org)

)

entry(
index = 80,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C3H6X2 and C3H5X2 are bidentate species and I don't think this should match this family

)

entry(
index = 82,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C3H5X2-2 and C3H4X2 are bidentate species

)

entry(
index = 83,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C3H5X2-3 and C3H4X2-2 are bidentate species

only with Eas, As are None
these are reactions which currently dont match any of our families
The duplicate cathub reactions were converted to MultiArrh.  However, we do not want to add these rates together, so I converted them to SurfaceArrhenius and selected the more recent calculation (SchumannSelectivity2018)
Since we now consider metal attrs when descending the tree, these need to be removed from thermo group entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants