Tree Generation for Cyclic Ether Formation #487
Conversation
| productNum = 2 | ||
|
|
||
| autoGenerated = False |
There was a problem hiding this comment.
I'm surprised at this line 🤔 . Is it a bug, or does in not mean what I think?
There was a problem hiding this comment.
I think currently autoGenerated is defaulted to False and needs to be changed to True manually. @mjohnson541 it might be nice to default this to True?
There was a problem hiding this comment.
It should be set to True here, I forgot to say that in developer hours. Having it be default True would be good once we've converted the majority of the trees, but right now we'd have to go through and manually set it to False for most of the families so I think for the moment it's easier to just add it?
There was a problem hiding this comment.
Or actually much better we should automatically set it when we generate the tree so that when it saves it saves as True!
There was a problem hiding this comment.
added this to the assorted PR in RMG-Py
xiaoruiDong
force-pushed
the
ATG_cyclic_ether_formation
branch
from
d83b542
to
648f7fa
Compare
xiaoruiDong
force-pushed
the
ATG_cyclic_ether_formation
branch
from
648f7fa
to
7a5b7e1
Compare
xiaoruiDong
changed the title
xiaoruiDong
force-pushed
the
ATG_cyclic_ether_formation
branch
from
c2122df
to
1deff25
Compare
Replace the logic node to a more generalized node; Removed all nodes previously defined; Add number of reactants and products.
This will be replaced by new rules created by ATG anyway
The new rate rules are generated by the BM tree fitting notebook.
xiaoruiDong
force-pushed
the
ATG_cyclic_ether_formation
branch
from
1deff25
to
2c8605f
Compare
Generated tree for Cyclic Ether Formation family. This is generated following the guidance of RMG developer hour (Jun 7, 2021).
Note: