Make polycyclic pass sibling parent testing #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid failure of parent children checking; Note: side ene means there's double bond existing outside cyclics, normal ene means double bond inside cyclics
It is not a problem if siblings have a children/parent relationship as long as the child is placed before the parent. The previous test was too restrictive causing problems for the trees in the polycyclic thermo groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously sibling and parent checking is deactivated for polycyclics because we don't want some siblings in polycyclics to be parent-children relationship although structure-wise they are parent-children. For instance, tricyclics have more specific structures than bicyclics so current sibling parent testing will complain that tricyclics should be under bicyclics, however we don't want using tricyclics ring strains to average for bicyclics ring strains. It's more chemically more sensible to have tricyclics and bicyclics as siblings. For current testing, we should place tricyclics before bicyclics to avoid failure of sibling parent testing. This PR reorganize the tree a bit to achieve that.