Skip to content

Commit

Permalink
Merge pull request #660 from ssun30/group_fit_script_patch
Browse files Browse the repository at this point in the history
Removes duplicate bad fits in the Benson Group Fitting Notebook.
Currently the block checking for bad fits will repeatedly add the species index with bad fit if more than one criterion for bad fits is met. This makes the output cell very long if there are multiple "bad fit species". This PR removes the duplicates as well as providing feedback on how many species out of the library have bad fits.
  • Loading branch information
rwest authored Aug 15, 2024
2 parents 5adb637 + ff6fd09 commit bae334b
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion scripts/fitThermoGroupsFromThermoLibrary.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -1360,10 +1360,20 @@
" if diff_new>n*4.18:\n",
" bad_fit_spc_index_list.append(spc_index)\n",
" \n",
"bad_fit_spc_index_list = list(set(bad_fit_spc_index_list))\n",
"print(f\"{len(bad_fit_spc_index_list)} out of {len(entries)} species have bad fits\")"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"for spc_index in bad_fit_spc_index_list:\n",
" print(\"Warning: these are bad fits:\")\n",
" check_data(index=spc_index)\n",
" print(\"====\")"
" print(\"===========================================================================\")"
]
},
{
Expand Down

0 comments on commit bae334b

Please sign in to comment.