Skip to content

Commit

Permalink
Remove Surface_Addition_Single_vdW family which is a duplicate (PR #656)
Browse files Browse the repository at this point in the history
The reaction family Surface_Addition_Single_vdW is the reverse reaction of Surface_Dissociation_Beta_vdW. 
There is no need to have both families. In this PR Bjarne removed the Surface_Addition_Single_vdW 
family since we have BEP rate rules for Surface_Dissociation_Beta_vdW. 
Surface_Addition_Single_vdW had some training reactions, which he integrated into the
Surface_Dissociation_Beta_vdW to keep the data in RMG. The Surface_Addition_Single_vdW 
is not turned on by default in RMG since it is in the surface_development list of recommended.py.

See #656 for more details.
  • Loading branch information
rwest committed Sep 19, 2024
2 parents c609c33 + ccdacda commit affd292
Show file tree
Hide file tree
Showing 11 changed files with 332 additions and 1,680 deletions.
Binary file removed families/images/Surface_Addition_Single_vdW.png
Binary file not shown.
Binary file modified families/rmg_reaction_families.pdf
Binary file not shown.
649 changes: 0 additions & 649 deletions input/kinetics/families/Surface_Addition_Single_vdW/groups.py

This file was deleted.

24 changes: 0 additions & 24 deletions input/kinetics/families/Surface_Addition_Single_vdW/rules.py

This file was deleted.

Binary file not shown.
Loading

0 comments on commit affd292

Please sign in to comment.