Fix problems with search for maxNetworkLeakRates during pruning #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cantherm was failing because it was still refering to LenardJones class which is now removed after the transport branch has been merged. Made the writing of output of measure also consistent to use TransportModel
Commit 5c4a2da would modify the label in the input file causing Cantherm to crash when its trying to calculate kinetics for that reaction.
- numPdepNetworks = self.networkCount was the number of PdepNetworks ever created in that model - len(self.networkList) is the number of actually existing PdepNetworks at any time fixes ReactionMechanismGenerator#176
- limit search on labeled atoms - this is currently RMG-specific to track electronic states as attribute of single atoms, we have to consider moving on to tracking it as a species property
|
Cherry-picked relevant commits onto master. Thanks Beat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #176