Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian unconverge trsh #758

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Gaussian unconverge trsh #758

merged 3 commits into from
Aug 15, 2024

Conversation

calvinp0
Copy link
Member

@calvinp0 calvinp0 commented Aug 6, 2024

There are times when we do not get convergence of the optimisation of a molecule and we only receive an output of l9999.exe. Currently, we do not make any drastic changes then to the input file for Gaussian for troubleshooting and may end up determining we cannot converge the molecule and therefore give up.

However, further up the file we may find the number of steps is a limit (the example output file shows 27 steps is the max for opt). Therefore, this aims to troubleshoot it by increasing the cycles for opt. Removed increase of scf maxcycle as DM/QC (512) have their own default values compared to default algorithm (128). If non-convergence is still not occuring, then checking if the scf is shaking manually should be done. https://wongzit.github.io/method-to-solve-the-scf-not-converged/

Edit: I have now included more methods for dealing with other errors, such as L502 - Inaccurate quadrature in CalDSu

I have attempted to provide comments against each trsh_keyword to explain what they do

@github-actions github-actions bot added the Module: trsh Troubleshooting label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 89.87342% with 16 lines in your changes missing coverage. Please review.

Project coverage is 73.96%. Comparing base (0bb9d9a) to head (b25f8b6).
Report is 4 commits behind head on main.

Files Patch % Lines
arc/job/trsh.py 81.35% 7 Missing and 4 partials ⚠️
arc/job/adapters/gaussian_test.py 91.66% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   73.82%   73.96%   +0.13%     
==========================================
  Files         101      101              
  Lines       27623    27776     +153     
  Branches     5795     5816      +21     
==========================================
+ Hits        20393    20544     +151     
+ Misses       5774     5773       -1     
- Partials     1456     1459       +3     
Flag Coverage Δ
unittests 73.96% <89.87%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JintaoWu98
JintaoWu98 previously approved these changes Aug 7, 2024
Copy link
Member

@JintaoWu98 JintaoWu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calvinp0 calvinp0 force-pushed the gaussian_unconverge_trsh branch 2 times, most recently from 6d424ba to e07ec32 Compare August 7, 2024 14:15
Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added one small comment

@@ -878,6 +887,8 @@ def trsh_ess_job(label: str,

# Check if SCF is in the keyword
ess_trsh_methods, trsh_keyword, couldnt_trsh = trsh_keyword_scf(job_status, ess_trsh_methods, trsh_keyword, couldnt_trsh)
if 'scf=(maxcycle=512)' in ess_trsh_methods:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 512?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a number that was suggested. There is no rhyme or reason why that value specifically. As I mentioned in the description, this troubleshoot addition is a last resort brute force.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the scf cycle increase as it would have consequences on certain aspects if this is being done automatedly.

@calvinp0 calvinp0 force-pushed the gaussian_unconverge_trsh branch 5 times, most recently from 0687958 to d6e9440 Compare August 11, 2024 21:04
Copy link
Member

@JintaoWu98 JintaoWu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calvinp0 calvinp0 merged commit 485eee4 into main Aug 15, 2024
7 checks passed
@calvinp0 calvinp0 deleted the gaussian_unconverge_trsh branch August 15, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: trsh Troubleshooting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants