Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QChem Adapter & Molpro Updates #712

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

QChem Adapter & Molpro Updates #712

wants to merge 31 commits into from

Commits on Feb 14, 2024

  1. job killed by walltime recognition

    the adapter now can recognise through additional information if the job was killed due to exceeding the wall time
    it also now has a troubleshoot queue function
    when writing the submit file, the function will now attempt to see if the user provided a dictionary of queue(s) with wall times and then place them in the submit file template
    
    Test:
    Written a test for the recognition of ServerTimeLimit keyword
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    62433b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21d0e0e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8054f43 View commit details
    Browse the repository at this point in the history
  4. It appears that when the function is using an OPT job to get an SP, i…

    …t attempts to consider all the OPT job but does not determine whether the OPT job has a status of done
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    690a831 View commit details
    Browse the repository at this point in the history
  5. It appears that when we submit the coords of a job (job.xyz) it is in…

    … string format sometimes. This additional if and regex statement will convert the string to a tuple, if possible
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2b59d29 View commit details
    Browse the repository at this point in the history
  6. only check qstat if zeus

    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d38e259 View commit details
    Browse the repository at this point in the history
  7. Updating trh server queue

    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c10e4f3 View commit details
    Browse the repository at this point in the history
  8. asis Set Dataframe

    Built a dataframe of possible combinations of basis sets that QChem requires and the correct format for the input file. Additionally, ensured that it is uploaded in the git push. This is a WIP as there may be more basis sets to add or even fix!
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    60dd90b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1011847 View commit details
    Browse the repository at this point in the history
  10. Molpro Adapter

    Molpro Adapter: Molpro needs a different touch to troubleshooting its memory. Here in setting the input file memory we determine if the MWords was enough per process but the total memory was too high. If that's the case, we reduce the processes req. while maintaining the memory per process
    Update
    Adjusted the file name to download from input.out to output.out
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9766ad9 View commit details
    Browse the repository at this point in the history
  11. QChem Adapter & Tests

     QChem Adapter
    
    0. QChem Adapter: Import - Pandas, ARC_PATH, rapidfuzz
    1. QChem Adapter: Input Template now supports IRC and {trsh} args and ensures IQMOL_FCHK is false (This can be set to true BUT be aware this .fchk file can be rather large)
    2. QChem Adapter: write_input_file - basis set is now matched via the software_input_matching function
    3. QChem Adapter: write_input_file - QChem now supports D3 method. We should look at working with other DFT_D methods in the future. More specifically there are other types of D3 methods
    4. QChem Adapter: write_input_file - Correctly pass in troubleshooting arguments into the input file
    5. QChem Adapter: write_input_file - Capitalised TRUE/FALSE in UNRESTRICTED parameter
    6. QChem Adapter: write_input_file - Removed the scan job type and moved it to another section of the input file writing
    7. QChem Adapter: write_input_file - If scan is set, the job_type is PES_SCAN. We also set the fine to be XC_GRID 3. However, we may need to look into changing the tolerances later
    8. QChem Adapter: write_input_file - We now write correctly the torsional scans for the input file for a scan
    9. QChem Adapter: write_input_file - IRC is now supported, however this input file means we run two jobs from the one input file - A  FREQ job and then IRC. This currently works but will need improvements when used more by users
    10. QChem Adapter: write_input_file - Ensuring that the SCF CONVERGENCE is 10^-8 for certain job types
    11. QChem Adapter: [NEWFUNCTION] generate_scan_angles - to support PES SCAN jobs, we have a function that will look at what the required angle we want to scan, and the step size, and then return a start and end angle between -180, 180 that will ensure we scan the require angle during the stepping
    12. QChem Adapter: [NEWFUNCTION] software_input_matching - Since QCHEM has different formatting for basis sets, this function will try take the users format of the basis set and match it against a dataframe (which should always be updated if its missing a format). This uses the new package in the ARC environment called rapidfuzz
    
    Additionally - Updated QChem Tests
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    189eb62 View commit details
    Browse the repository at this point in the history
  12. Updated Trsh and Trsh Tests

    TrshQChem: Added in new trsh keywrods
    
    TrshQChem: 'Error within run_minimization with minimization method' - Not certain what this error requires, and also if we should troubleshoot it if the job type is a 'conformer'. For now, we will re-run the job under the same conditions and if it fails again, we will declare it not possible to troubleshoot
    remove 'break'
    
    TrshMolpro: Parse new array length memory
    
    Updated Trsh Tests
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2a1738c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6ca490e View commit details
    Browse the repository at this point in the history
  14. Added azure in ess settings

    For future reference
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ff7583c View commit details
    Browse the repository at this point in the history
  15. QChem Normal Mode Displacement

    Added QChem for the Normal Mode Displacement parsing and also change the default bool for raise_error
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0c23475 View commit details
    Browse the repository at this point in the history
  16. Scheduler Updates and Changes

    1. Scheduler: Now imports JobError
    2. Scheduler: Fixed adding trsh to the args
    3. Scheduler: Added JobError exception for determining job status
    4. Scheduler: Now removing remote jobs at the end of the scheduler - !!!MAY NEED TO SEE IF THIS HAS AN EFFECT ON NON SSH JOBS!!!
    5. Scheduler: Getting the recent opt job name via properly checking if the opt job was considered done (This was not done before)
    6. Scheduler: TODO - We attempt to trouble shoot a frequency we deem not okay. Yet, there is no specific troubleshoot method, so why do we do this?
    7. Scheduler: Properly troubleshoot an job
    8. Scheduler: Fix conformer troubleshoot if it was a TS conformer
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    752f417 View commit details
    Browse the repository at this point in the history
  17. Various Settings Changes

    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4852981 View commit details
    Browse the repository at this point in the history
  18. Updating submit.py to support AZURE Slurm

    For future reference and good to know for SLURM servers
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    497628d View commit details
    Browse the repository at this point in the history
  19. [WIP] Getting the Internal Coordinates for QChem - Still not operati…

    …onal
    
    Needs further development and understanding
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e304459 View commit details
    Browse the repository at this point in the history
  20. Species: Get number of heavy atoms for TSGuess

    The original code did not functional correctly - nor was never used hence why it was passed into production. It has now been changed to properly return the actual number of heavy atoms
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6143254 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    2b9cd67 View commit details
    Browse the repository at this point in the history
  22. Update ARC Environment

    Added in rapidfuxx
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d68720f View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    abb4d7f View commit details
    Browse the repository at this point in the history
  24. Removed: remove_remote_files

    This function will be required for later use when SSH is updated. For the time being, better to remove. It also causes an error in xTBAdapater (has no attribute remove_remote_files)
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9e49d7f View commit details
    Browse the repository at this point in the history
  25. Update spelling

    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a4a3189 View commit details
    Browse the repository at this point in the history
  26. Molpro Mem/CPU Change Tests

    Molpro Memory Set Update
    
    Will now limit the memory of Molpro to what is req. by Molpro if the CPU is set 1 core.
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fd6bee1 View commit details
    Browse the repository at this point in the history
  27. deduce software - irc

    If user has both software available for IRC,  it will use go with preferred order
    
    level tests update
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    dc366c6 View commit details
    Browse the repository at this point in the history
  28. molpro test updates

    Fixed local var min_mem_value
    
    Update core reduction logic test for MP
    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2f581fd View commit details
    Browse the repository at this point in the history
  29. Updates

    calvinp0 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    bc3dc82 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Updates

    calvinp0 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    f29012c View commit details
    Browse the repository at this point in the history
  2. Updates

    calvinp0 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5e4b433 View commit details
    Browse the repository at this point in the history