New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli fix #37

Open

BumbleB2na wants to merge 2 commits into ReactTraining:main from BumbleB2na:cli-win-fix

BumbleB2na commented Apr 22, 2021

Fixes course compile on windows without wsl.

Resolves issue: #33

Testing considerations

was tested using powershell, same environment as described in linked issue
was not tested on mac
was not tested on linux

BumbleB2na added 2 commits

April 22, 2021 05:25


          fixes course compile in cli on non-wsl windows

aed277c


          fixes course compile in cli on non-wsl windows

a6c7f27

ccjoshk commented May 27, 2021

Thanks @BumbleB2na for this. I had this issue on Windows this morning and these changes fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet