Merge pull request #528 from kukchanka/fix-maximum-update-depth-exceeded

fix(getPosition): updated getPosition to fix 'maximum update depth'
ReactTooltip · Jan 4, 2020 · d1d009c · d1d009c
2 parents 59a589e + 8fda305
commit d1d009c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/utils/getPosition.js b/src/utils/getPosition.js
@@ -86,10 +86,11 @@ export default function (e, target, node, place, desiredPlace, effect, offset) {
 
   let isNewState = false
   let newPlace
-  if (inside(desiredPlace) && desiredPlace !== place) {
+  let shouldUpdatePlace = desiredPlace !== place
+  if (inside(desiredPlace) && shouldUpdatePlace) {
     isNewState = true
     newPlace = desiredPlace
-  } else if (insideList.length > 0 && outside(desiredPlace) && outside(place)) {
+  } else if (insideList.length > 0 && shouldUpdatePlace && outside(desiredPlace) && outside(place)) {
     isNewState = true
     newPlace = insideList[0]
   }