Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Floating Solo Toolbar v1.0 #1489

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Neftovsky
Copy link

No description provided.

@cfillion
Copy link
Member

cfillion commented Jan 19, 2025

  • Scripts should use sentence case to blend well with native actions and other scripts: "Floating solo toolbar", perhaps "Neft's floating solo toolbar" (but there's already neftofsky_ shown in front, so it'd be a bit redundant?), etc...
  • Typo: "-aves" in the @about text
  • Public ReaImGui-based scripts must enable backward compatibility by specifying which API version they are written for (see examples at https://forum.cockos.com/showthread.php?t=250419)

Suggestion: it might be a good idea to save the settings in the same folder as the script's file rather than hard-coded to the resource path's root.

@Neftovsky Neftovsky changed the title Release Neft Floating Solo Toolbar v1.0 Release Floating Solo Toolbar v1.0 Jan 19, 2025
@cfillion
Copy link
Member

cfillion commented Jan 19, 2025

To enable backward compatibility, it's:

package.path = reaper.ImGui_GetBuiltinPath() .. '/?.lua'
require 'imgui' '0.X.Y'

Since the script uses the now-removed DestroyContext function, it looks like it was written for an older version of ReaImGui? Specify which one in the require line so that it can work with today's (0.9) and tomorrow's versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants