Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Scroll TCP to track currently edited in active MIDI editor v0.5 #1453

Conversation

BenTalagan
Copy link
Contributor

Simple script to scroll the TCP so that the currently active MIDI editor's take's track appears at the top of the arrange view.

@cfillion
Copy link
Member

cfillion commented Nov 8, 2024

Wouldn't the MIDI Editor category be a better fit for this than Various?

@BenTalagan
Copy link
Contributor Author

BenTalagan commented Nov 8, 2024

Good question ! I've been hesitating for a while on this ; at first I had put it into the "View" category like it's done in @X-Raym's repository before realizing this categorization was specific to him. Since it scrolls the arrange view, it's something hybrid between the MIDI editor and the arrange view, but because it has no effect when there's no open MIDI editor, it's probably better categorized in the MIDI Editor section. Changing this ...

@BenTalagan
Copy link
Contributor Author

Ok, done !

@X-Raym
Copy link
Member

X-Raym commented Nov 8, 2024

@BenTalagan MIDI Editor is the only reapacl specific name folder to determine context.

What matters here is not on what it is triggered but from where. I imagine this action on MIDI editor toolbar so better put it there indeed.

@BenTalagan
Copy link
Contributor Author

@X-Raym I don't think it would not necessarily be triggered from the MIDI editor toolbar (could be in more generic actions that handle the current global layout), and it's just technically a small "brick" anyway (I don't use it alone), so even if there's a good chance that it appears in a custom action launched from the MIDI toolbar, I've still added it to both action sections [main, midieditor], but you're right, the probabilities are largely in favor of the MIDI Editor, so let's go this way ! It's already done anyway :-)

`@metapackage` removes the package file from the filelist yet `@provides` adds it right back.
@cfillion cfillion merged commit 7ed3b25 into ReaTeam:master Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants