Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Play lanes in time selection v1.00 #1445

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

Edgemeal
Copy link
Contributor

No description provided.

@cfillion cfillion merged commit b4aeefd into ReaTeam:master Oct 23, 2024
1 check passed
@Edgemeal
Copy link
Contributor Author

I try to update this script to v1.01, but I got error on reapack.com when I click the pull request button.
Error: There are merge conflicts

@cfillion
Copy link
Member

cfillion commented Oct 23, 2024

Your fork's master branch is 4 commits ahead and 2 commits behind upstream so the upload tool can't bring it up-to-date. Reset it so that it matches the history of this repo (or just delete/re-create it).

@Edgemeal
Copy link
Contributor Author

Thanks, did the Discard 4 commits option, reapack uploaded with no errors, hope that worked!

@cfillion
Copy link
Member

Yup, all good. By the way, a slightly more robust check for ReaImGui's absence would be if not reaper.ImGui_GetBuiltinPath then since that's the only function meant to be used before enabling backward compatibility.

It's extremely unlikely, but let's say in 10 years Begin gets renamed to BeginWindow. The script would normally still work thanks to the backward compat, however it would then fail the presence check.

Whereas ImGui_GetBuiltinPath must not ever be removed because that would break every script.

@Edgemeal
Copy link
Contributor Author

Thanks, Good to know!
Will change it for next update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants