Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Song switcher (for live use) v1.7 #1441

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

cfillion
Copy link
Member

run action markers from take markers in the current song's primary track (REAPER v6+)

run action markers from take markers in the current song's primary track (REAPER v6+)
@cfillion cfillion merged commit 599dd8d into ReaTeam:master Oct 13, 2024
1 check passed
@cfillion cfillion deleted the reapack.com_upload-1728789227441 branch October 13, 2024 03:21
@mschnell1
Copy link
Contributor

mschnell1 commented Oct 13, 2024

You might have noticed that I rewrote some parts of the song switcher (in eel, as I don't understand LUA ) to allow for having it work in a background project. Works fine, but of course just a single "song switcher" project would be better. Maybe you might consider adding that functionality to the "main" song switcher protect,

@cfillion
Copy link
Member Author

cfillion commented Oct 13, 2024

Do you mean like in #1442? Fixes song validation not supporting background tabs (= the song turns to red even though the track still exists).

The new take action marker functionality does support background tabs.

@mschnell1
Copy link
Contributor

mschnell1 commented Oct 13, 2024

I am not sure.
What I intended with "Mini Song Switcher" is to have the Songs be hosted in a dedicated background project tab and be controlled by Midi activity in the foreground Tab. Hence when "calling" a song you need to give not only the track (I did this in the same way as "song switcher") but additionally the (potentially background) Tab to be accessed (i.e. started / stopped),while the "running" state of the foreground tab is not affected . This can be done by ...._X() API calls.

@cfillion
Copy link
Member Author

cfillion commented Oct 13, 2024

With that bugfix the "Switch to xyz" actions work no matter what is the current active tab. As long as the songs are themselves all in the same project.

(If there are multiple project tabs with songs instead of one, changes can be done by combining with the "Reset data" action to reload the song list. Change active tab, reset song switcher data, switch song, return to previous tab. Can be wrapped in a script with PreventUIRefresh.)

@mschnell1
Copy link
Contributor

mschnell1 commented Oct 13, 2024

The primary "problem" I found at that time was not about switching but about starting / stopping.
The "Song Switcher" started the Tab in foreground, while the "Mini Song Switcher" can be configured to start / stop a project tab defined by the user. (Issue with my setup: the foreground Tab is used to host the instruments played by Midi Keyboard. )

Solution: using the ....Ex() API, which allow to specify the Tab to be addressed. (e.g. "Main_OnCommandEx")

(Dynamically switching the active Tap and then back when a Midi Message is received seems not like a really good way.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants