Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Mini song switcher v2.1 #1411

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

mschnell1
Copy link
Contributor

Allow for accessing multiple project tabs
bug fixes

Allow for accessing multiple project tabs
bug fixes
@mschnell1
Copy link
Contributor Author

mschnell1 commented Jun 29, 2024

@cfillion
Version 2 now features two eel files.
Is there a problem with that ?

This lin

 @provides [main] mschnell_Mini song switcher/New file 1.lua > mschnell_Mini song switcher/mschnell_Mini song switcher project.eel

seems weird to me. but it seems to be automatically generated

Thanks !

@cfillion
Copy link
Member

It shouldn't be named "New file 1.lua". (Guessing you've changed the "install filename" instead of the "storage filename")

@mschnell1
Copy link
Contributor Author

@cfillion
Will it work now ?

@mschnell1
Copy link
Contributor Author

remove duplicate header block

Thanks, but

Still does not seem to work....

@cfillion
Copy link
Member

cfillion commented Jul 1, 2024

Still does not seem to work....

It doesn't work? If there's a bug in the script I'll hold off merging this until it's fixed then...

@mschnell1
Copy link
Contributor Author

mschnell1 commented Jul 2, 2024

Still does not seem to work....

It doesn't work? If there's a bug in the script I'll hold off merging this until it's fixed then...

I do suppose the scripts work.

I meant pushing the v2.1 package to ReaPack did not work, even though I did get a "has been merged" message.

@cfillion cfillion merged commit 312ae97 into ReaTeam:master Jul 2, 2024
1 check passed
@cfillion
Copy link
Member

cfillion commented Jul 2, 2024

even though I did get a "has been merged" message.

I merged it now, it wasn't before.

@mschnell1
Copy link
Contributor Author

mschnell1 commented Jul 2, 2024

@cfillion
The second script 'mschnell_Mini song switcher project.eel' starts with a line -- @noindex, that somehow has been added by ReaPack.

Reaper cant compile that :(

What can I do about that ?

@cfillion
Copy link
Member

cfillion commented Jul 2, 2024

Ah yeah, it was added by the web upload tool because the file was in .lua ("New file 1.lua"). It would have added // @noindex if the filename had ended in .eel. I've fixed it in #1412. Named it v2.1.1, good to go?

@mschnell1
Copy link
Contributor Author

@cfillion
Yep. should work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants