Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Remove sleep timer menu restrictions #3637

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

zainarbani
Copy link
Contributor

@zainarbani zainarbani commented Sep 13, 2024

Screenshots

image1

image2

TODO

@cyberboh
Copy link

If you press Close, will YouTube close, and will you no longer be able to open it?

@zainarbani
Copy link
Contributor Author

If you press Close, will YouTube close, and will you no longer be able to open it?

If the user still 'awake' then press close to continue watching, or simply ignore it (sleep) then screen will go off by itself.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube): Unlock sleep timer menu feat(YouTube): Remove sleep timer menu restrictions Sep 13, 2024
@cyberboh
Copy link

@LisoUseInAIKyrios the tittle shouldn't changed, it's to unlock the timer, not to remove it, imo

@LisoUseInAIKyrios
Copy link
Contributor

The PR title is the same as the patch name, and its similar to the Remove background playback restrictions.

This PR removes all restrictions for using the sleep timer, including the a/b account selection restriction since sleep timer is an experimental feature.

@LisoUseInAIKyrios
Copy link
Contributor

This could use a new hide fly out setting, to hide the feature if the user doesn't want it.

Looks like the buffer string yt_outline_moon_z_ works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants