feat: Add Disable analytics and telemetry patches
#3448
Conversation
There was a problem hiding this comment.
Looks good on first sight. Once the couple style/refactor issues are addressed it lgtm. I do not know if each patch works here as expected, were they all been tested? The readme of the repository should be changed in this pr as well to include privacy patches as a feature, given this pr introduces pretty much all the common ones.
|
What other apps has this been tested on? I wonder if it would be simpler if all of these were bundled together into a single universal patch. Since not all sub patches will work for every app, it could not throw ugly exceptions and instead print to the console what patches succeeded and what did not. Something like: (See the remove share targets patch for how to log) And add patch options to turn off each sub patch if someone wanted (but I think most users would want everything included by default if they chose this patch). |
|
That sounds like a good idea indeed. |
|
To make simpler logs, could be instead of |
src/main/kotlin/app/revanced/patches/all/analytics/facebook/DisableFacebookAnalytics.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/all/analytics/UniversalPrivacyPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/all/analytics/UniversalPrivacyPatch.kt
Outdated
Show resolved
Hide resolved
...kotlin/app/revanced/patches/all/analytics/appsflyer/fingerprints/AppsFlyerInitFingerprint.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/all/privacy/UniversalResourcePrivacyPatch.kt
Outdated
Show resolved
Hide resolved
…e root level initializer rather than at the wrapper level
|
Are there any todo's left for this PR? Just for reference, what apps has this been tested on and it works? |
|
I am locally refactoring this PR. I'll push it soon |
oSumAtrIX
changed the title
Disable analytics and telemetry patches
| val applicationNode = getNode("application") as Element | ||
| applicationNode.getElementsByTagName(META_DATA_TAG) | ||
| .asSequence() | ||
| .first { it.attributes.getNamedItem(NAME_ATTRIBUTE).nodeValue == nodeName } |
There was a problem hiding this comment.
I replaced firstOrNull with first here when refactoring. Correct this if it should be firstOrNull. If it should, then the try captch block above isn't necessary which was present before I refactored.
| object DisableAnalyticsAndTelemetryThroughManifestPatch : ResourcePatch() { | ||
| private val logger = Logger.getLogger(this::class.java.name) | ||
|
|
||
| private val disableFirebaseTelemetry by option("Firebase telemetry") |
There was a problem hiding this comment.
I merged the two firebase patches to one.
| private val disableFirebaseTelemetry by option("Firebase telemetry") | ||
| private val disableFacebookSdk by option("Facebook SDK") | ||
| private val disableGoogleAnalytics by option("Google Analytics") |
There was a problem hiding this comment.
GAnalytics patch also exists in the bytecode patch, why is it present here as well? Also, can't the firebase & facebook patches be converted to bytecode?
LisoUseInAIKyrios
force-pushed
the
dev
branch
from
feefb56
to
a371631
Compare
oSumAtrIX
force-pushed
the
dev
branch
2 times, most recently
from
c0cd9d2
to
2ace07d
Compare
Added generic patches to disable multiple analytics and telemetry SDKs: ComScore, AppsFlyer, MoEngage, Segment, Statsig, Facebook SDK, Google Analytics, Firebase Crashlytics, Firebase Logging
Those are all the SDKs included in the SoundCloud app, and the patches were developed and tested on it but should work for any app.
This greatly increases privacy but also performance, more specifically regarding the startup time. SoundCloud initializes and opens up noticeably faster using those patches.