Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Translations): Translations for YouTube and Twitch #2366

Closed
wants to merge 206 commits into from
Closed

feat(Translations): Translations for YouTube and Twitch #2366

wants to merge 206 commits into from

Conversation

LisoUseInAIKyrios
Copy link

@LisoUseInAIKyrios LisoUseInAIKyrios commented Jun 6, 2023

Removed usage of StringResource, and moved all strings into Strings.xml files which allows easy localization.

Added translations for a few random languages (machine translated to show it works. Preferably should be replaced with Crowdin or some other human translated source)

Translation files are bundled automatically, just add or remove the translated Strings.xml files to either youtube/translation or twitch/translation.

Hebrew:
hebrew settings
hebrew sponsorblock

French (ooh là là):
french sponsorblock

French Twitch:
french twitch

integration changes

@0xrxL
Copy link

0xrxL commented Jun 6, 2023

Crowdin is a better solution imho.

Better to translator too (with its UX).

@0xrxL
Copy link

0xrxL commented Jun 6, 2023

@oSumAtrIX Do you think Crowdin it's a good solution ReVanced translations?

@oSumAtrIX
Copy link
Member

Crowdin is already used.

@oSumAtrIX
Copy link
Member

Crowdin is a better solution imho.

Better to translator too (with its UX).

This PR is necessary for Crowdin to work.

# Conflicts:
#	src/main/kotlin/app/revanced/patches/youtube/ad/getpremium/bytecode/patch/HideGetPremiumVideoAdvertisementPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/autorepeat/patch/AutoRepeatPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/video/hdrbrightness/patch/HDRBrightnessPatch.kt
LisoUseInAIKyrios and others added 11 commits November 11, 2023 20:41
# Conflicts:
#	src/main/kotlin/app/revanced/patches/youtube/layout/hide/general/HideLayoutComponentsPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/links/BypassURLRedirectsPatch.kt
# Conflicts:
#	src/main/kotlin/app/revanced/patches/youtube/layout/startupshortsreset/DisableResumingShortsOnStartupPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/microg/MicroGResourcePatch.kt
## [2.198.1-dev.2](ReVanced/revanced-patches@v2.198.1-dev.1...v2.198.1-dev.2) (2023-11-19)

### Bug Fixes

* **Twitch - Settings:** Constrain to last working version ([a3e275b](ReVanced/revanced-patches@a3e275b))
* **Yuka - Unlock premium:** Constrain to last working version ([9b855f0](ReVanced/revanced-patches@9b855f0))
# Conflicts:
#	src/main/kotlin/app/revanced/patches/shared/settings/util/AbstractPreferenceScreen.kt
#	src/main/kotlin/app/revanced/patches/youtube/layout/hide/general/HideLayoutComponentsPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/layout/hide/seekbar/HideSeekbarPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/layout/seekbar/SeekbarPreferencesPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/announcements/AnnouncementsPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/fix/playback/SpoofSignaturePatch.kt
# Conflicts:
#	CHANGELOG.md
#	gradle.properties
#	patches.json
#	src/main/kotlin/app/revanced/patches/youtube/layout/hide/rollingnumber/DisableRollingNumberAnimationPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/layout/hide/seekbar/HideSeekbarPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/announcements/AnnouncementsPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/privacy/RemoveTrackingQueryParameterPatch.kt
# Conflicts:
#	src/main/kotlin/app/revanced/patches/youtube/layout/hide/general/HideLayoutComponentsPatch.kt
# Conflicts:
#	src/main/kotlin/app/revanced/patches/twitch/misc/settings/SettingsPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/layout/seekbar/RestoreOldSeekbarThumbnailsPatch.kt
# Conflicts:
#	src/main/kotlin/app/revanced/patches/shared/settings/AbstractSettingsResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/interaction/copyvideourl/CopyVideoUrlResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/interaction/downloads/ExternalDownloadsResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/interaction/swipecontrols/SwipeControlsResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/layout/returnyoutubedislike/ReturnYouTubeDislikeResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/layout/sponsorblock/SponsorBlockResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/microg/MicroGResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/minimizedplayback/MinimizedPlaybackPatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsResourcePatch.kt
#	src/main/kotlin/app/revanced/patches/youtube/video/speed/remember/RememberPlaybackSpeedPatch.kt
#	src/main/kotlin/app/revanced/util/microg/MicroGResourceHelper.kt
#	src/main/kotlin/app/revanced/util/resources/ResourceUtils.kt
#	src/main/resources/youtube/stringspatch/host/values/ReturnYouTubeDislike.xml
@oSumAtrIX
Copy link
Member

Hey, just letting you know that we have renamed repositories. Please close this PR and re-open it here. PS: No additional changes are needed to your remotes.

@LisoUseInAIKyrios
Copy link
Author

Pull request moved to ReVanced/revanced-patches#2440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants