Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReturnYouTubeDislike patch fix #1345

Closed
wants to merge 1 commit into from
Closed

ReturnYouTubeDislike patch fix #1345

wants to merge 1 commit into from

Conversation

LisoUseInAIKyrios
Copy link

patch adjustment for latest YouTube

@oSumAtrIX
Copy link
Member

This PR is not fixing anything as this repository targets the latest revanced-patcher version which can resolve fingerprints on sub-string references. Context: ReVanced/revanced-patches#1309 (comment).

@oSumAtrIX oSumAtrIX closed this Dec 22, 2022
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the returnyoutubedislike_patch_fix branch December 22, 2022 12:00
@LisoUseInAIKyrios
Copy link
Author

A cli release should be published soon, as currently RYD is broken if patching with the manager using it's default settings.

@oSumAtrIX
Copy link
Member

Releases are figured by semantic release. We can't force release a version unless theres a releasing commit. You could make a PR to fix some generic issue or improve performance or similar which would trigger release.

@LisoUseInAIKyrios
Copy link
Author

ReVanced/revanced-patcher@c5de9e2

If this change is merged into the main branch and a released is published, then RYD would work again when patching using the manager.

@oSumAtrIX
Copy link
Member

This commit is already available in this release: https://github.com/revanced/revanced-patcher/releases/tag/v6.3.2.
The patches use this version. The CLI does too in the latest commit, but is not released yet.

@LisoUseInAIKyrios
Copy link
Author

LisoUseInAIKyrios commented Dec 22, 2022

Ok so the problem is not affecting the official manager, but instead only when building on command line.

Although that includes 3rd party (unsupported) tools to build ReVanced.

@oSumAtrIX
Copy link
Member

3rd party is out of our reach. There is no problem, the CLI is just missing a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants