Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ubi_reader dependency #648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ubi_reader dependency #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ function install_cramfstools

function install_ubireader
{
git clone --quiet --depth 1 --branch "master" https://github.com/jrspruitt/ubi_reader
git clone --quiet --depth 1 -b v0.8.5-master https://github.com/jrspruitt/ubi_reader
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, we could achieve the same effect (without pinning to an outdated tag) by just switching main to master. Either way, I support this change to un-break the deps.sh script!

Suggested change
git clone --quiet --depth 1 -b v0.8.5-master https://github.com/jrspruitt/ubi_reader
git clone --quiet --depth 1 --branch "main" https://github.com/jrspruitt/ubi_reader

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't enough anymore, since newer version of ubi_reader use Poetry instead of setuptools (there's no setup.py).

I think the correct solution here is to edit deps.sh to install ubi_reader from PyPi instead of source (i.e. run pip install ubi_reader).

(cd ubi_reader && $SUDO $PYTHON setup.py install)
$SUDO rm -rf ubi_reader
}
Expand Down