Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deps.sh to reflect branch rename in ubi_reader from 'master' … #636

Closed
wants to merge 1 commit into from

Conversation

Neowizard
Copy link

The maintainers over at UBI Reader changed their default branch name to "main" yesterday. The clone commands in deps.sh assumes there's a "master" branch which broke deps.sh, so I changed it to clone the "main" branch instead of "master"

HoxhaEndri added a commit to HoxhaEndri/binwalk that referenced this pull request May 25, 2023
@marcellomaugeri
Copy link

@Neowizard this fix cannot work since in the "main" branch there is no setup.py anymore

@Neowizard
Copy link
Author

Neowizard commented Jun 8, 2023

Yeah, they made yet another breaking change over at ubi_reader when they moved to Poetry...

Wouldn't it be better, at this point, if binwalk would install ubi_reader from PyPi using pip?

I worked around this issue with a sed one-liner

sed -i '/git clone --quiet --depth 1 --branch "master" https:\/\/github\.com\/jrspruitt\/ubi_reader/c\pip install ubi_reader; return' ./deps.sh

@devttys0 devttys0 closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants