Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MeetYourHostSection component responsive and dynamic #338

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

grabinskij
Copy link
Collaborator

@grabinskij grabinskij commented Dec 3, 2024

This PR makes the meetYourHostSection responsive and dynamic. Also the broken pictures in place.json for meetYourHostSection were replaced with new ones.

It will be easier to review after Feature/responsive gallery #348 will be merged since the components from #348 PR will have no bad impact to the current component.

meetHost

@@ -41,7 +41,7 @@ const ProductPage = () => {
const [error, setError] = useState(null);

const isInitializedRef = useRef(false)

console.log('place', place)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you noticed it. I have it deleted.

@orYoffe
Copy link
Collaborator

orYoffe commented Dec 3, 2024

I can't see the area.. is there a way to validate the PR otherwise?
Screenshot 2024-12-03 at 18 56 49

@orYoffe
Copy link
Collaborator

orYoffe commented Dec 3, 2024

by removing other components in the browser

I'd say "by removing other components in the browser" is not really great.. anyway you can make it actually work? 😄

@grabinskij
Copy link
Collaborator Author

by removing other components in the browser

I'd say "by removing other components in the browser" is not really great.. anyway you can make it actually work? 😄

I have deleted all components exept Header, otherwise it couldnot be posible for me separate the component and work with it.

@grabinskij grabinskij merged commit c545fcd into main Dec 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make meetYourHostSection responsive
3 participants