Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search function to latest places.json and fix bug related to d… #258

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

dvnishshanka
Copy link
Collaborator

  1. In this ticket I have updated the search functionality at the backend according to the latest places.json file.
  2. Fixed a bug when reading dates from json format. As the dates are saved in JSON as strings they need to be converted to dates.
    image

Please note that as the search panel is not able to take the user inputs values are hard coded.
Places.json file data is changed to show some results for the test data.

Copy link
Collaborator

@BhagyaPrasadSamarathunga BhagyaPrasadSamarathunga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done

destination = "US";
checkIn = new Date(2024, 11, 2);
checkOut = new Date(2024, 11, 3);
region = "uS";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uS" is this need to be change in to "US"

@dvnishshanka dvnishshanka merged commit c371c9e into main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the search result feature as per latest product.json data
3 participants