Review version(1.0) #7
Conversation
| }); | ||
| }; | ||
| const handleSubmit = (event) => { | ||
| setLoading(true); |
There was a problem hiding this comment.
onSubmit the spinner should be hidden so do you think the right value here is true?
| import { Card, Badge } from "react-bootstrap"; | ||
|
|
||
| function MovieItem(props) { | ||
| const { item } = props; |
There was a problem hiding this comment.
you can pass the {movies} object immediately MovieItem({movies}) without this line and use it in the return()
ex:
<h1>{movies.original_title}</h1>
|
|
||
| function MovieItem(props) { | ||
| const { item } = props; | ||
| const img = `https://image.tmdb.org/t/p/w500${item.poster_path}`; |
There was a problem hiding this comment.
I would prefer if it's done in this way:
<img src={IMG_BASE_URL + item.poster_path} alt="img"></img>
in the card body
| return ( | ||
| <Container className="mt-5"> | ||
| <Row> | ||
| {props.movies.map((movies) => ( |
There was a problem hiding this comment.
for better naming (movies) =>> (movie)
|
|
||
| function moviesData(query) { | ||
| return fetch(`${moviesUrl}&query=${query}`).then((movies) => movies.json()); | ||
| } |
There was a problem hiding this comment.
is the fetch working? because in the demo it's not.
There was a problem hiding this comment.
Thank you Mustafa for the comments, i fixed all except the demo one cause it is working in the vscode but there are some issues in the github page.
Team members:
*Mahmoud Mansour
*Zainab Saud
*Shadan Abdulkarim
*Ahmad Duhoki
https://ahmadduhoki.github.io/iraq-bc-movies-project-students/