Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial setup for the forntend #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Davut97
Copy link
Contributor

@Davut97 Davut97 commented Jul 19, 2020

i created the initial setup for the front end, i had to create Makefile.default in order to use the same commends for backend and fornt end, and avoid copying.

@louisrli
Copy link
Contributor

actually in this case, you should use the different makefile for frontend and backend, even if you have to copy.

think of it more like coincidence that they happen to be the same, but in general, frontend and backend are considered completely different products. for example, imagine this: i made the frontend and you made the backend. we don't see each other's code. someone should be able to ONLY use your backend folder in order to run the backend (they may run on completely different machines and so on). the short version of this is that you should think of them as completely separate entities

the spirit of not copying is good though :)

Aydin/frontend/dockerfile Show resolved Hide resolved
@Davut97
Copy link
Contributor Author

Davut97 commented Jul 19, 2020

for the makefike, backend and frontend have different file, but there is use "commands" ( i dont know what call them) are in common:
develop:
@ $(COMPOSE) up -d
@ $(COMPOSE) exec $(CONTAINER_NAME) /bin/bash ||true
@ $(COMPOSE) stop
@ $(COMPOSE) down
so i thought i should put it in a different file, just to avoid copying. please if i got it wrong let me know.

@louisrli
Copy link
Contributor

yes, i see the common code, but please read the reasoning in the message i wrote

@Davut97
Copy link
Contributor Author

Davut97 commented Jul 27, 2020

PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants