-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type coercion in bmerge #6603
base: master
Are you sure you want to change the base?
Conversation
Generated via commit 1d7a8c2 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6603 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 79 79
Lines 14516 14520 +4
=======================================
+ Hits 14314 14318 +4
Misses 202 202 ☔ View full report in Codecov by Sentry. |
@MichaelChirico is it worth to make the (length(unique(icols))!=length(icols) || length(unique(xcols))!=length(xcols)) ensuring that either |
Closes #6602
NB: I'm not happy that a user can get different messages, depending on the number of join conditions, but coercing both Dates to
double
when multiple column conditions exist, seems like the right decision.Base does not encounter this problem since one join column can not be in multiple join conditions.