Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divergence #6599

Closed
wants to merge 1 commit into from
Closed

Fix divergence #6599

wants to merge 1 commit into from

Conversation

ben-schwen
Copy link
Member

Closes #6587

@ben-schwen ben-schwen changed the base branch from master to patch-1.16.2 November 3, 2024 15:07
@ben-schwen ben-schwen closed this Nov 3, 2024
@ben-schwen ben-schwen deleted the fix_diverge branch November 3, 2024 15:08
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 95.02370% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (patch-1.16.2@f16111e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/forder.c 0.00% 6 Missing ⚠️
src/dogroups.c 78.94% 4 Missing ⚠️
src/assign.c 94.73% 2 Missing ⚠️
src/fread.c 95.34% 2 Missing ⚠️
src/reorder.c 50.00% 2 Missing ⚠️
R/data.table.R 98.57% 1 Missing ⚠️
src/bmerge.c 66.66% 1 Missing ⚠️
src/fmelt.c 66.66% 1 Missing ⚠️
src/freadR.c 87.50% 1 Missing ⚠️
src/gsumm.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             patch-1.16.2    #6599   +/-   ##
===============================================
  Coverage                ?   98.60%           
===============================================
  Files                   ?       79           
  Lines                   ?    14518           
  Branches                ?        0           
===============================================
  Hits                    ?    14316           
  Misses                  ?      202           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 3, 2024

Comparison Plot

Generated via commit 0cf6666

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 49 seconds
Installing different package versions 7 minutes and 52 seconds
Running and plotting the test cases 2 minutes and 28 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master diverges from patch 1.16.2
1 participant