-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently error when allocation request fails #6271
Conversation
Generated via commit 1cb8e1a Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 12 minutes and 31 seconds Time taken to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. Thanks!
maybe add a NEWS item about the linter?
Part of #1115
Also
free()
all objects when we allocate several consecutivelyCalloc()
, which is very explicitly advertised not to need this checking: https://cran.r-project.org/doc/manuals/r-release/R-exts.html#User_002dcontrolled-memoryTODO:
free(); free();
instead ofif (.) free(.)
, for conciseness