Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently error when allocation request fails #6271

Merged
merged 16 commits into from
Jul 16, 2024
Merged

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Jul 16, 2024

Part of #1115

Also

TODO:

  • Just use free(); free(); instead of if (.) free(.), for conciseness
  • Consistency in error for translation purposes
  • Come up with a way to prevent backsliding

Copy link

github-actions bot commented Jul 16, 2024

Comparison Plot

Generated via commit 1cb8e1a

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 31 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 32 seconds

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. Thanks!
maybe add a NEWS item about the linter?

@MichaelChirico MichaelChirico merged commit bca0d3e into master Jul 16, 2024
2 of 3 checks passed
@MichaelChirico MichaelChirico deleted the malloc-return branch July 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants