Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTECT() names vector #6265

Merged
merged 1 commit into from
Jul 21, 2024
Merged

PROTECT() names vector #6265

merged 1 commit into from
Jul 21, 2024

Conversation

MichaelChirico
Copy link
Member

Part of #6257.

This might resolve the issues there about rbindlist; the line numbers cited there don't seem correct, but this nearby does look incorrect.

@MichaelChirico MichaelChirico added this to the 1.16.0 milestone Jul 15, 2024
Copy link

Comparison Plot

Generated via commit 67865b8

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 52 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 17 seconds

@MichaelChirico
Copy link
Member Author

ping @ben-schwen :)

@ben-schwen
Copy link
Member

LGTM, ty!

@ben-schwen ben-schwen merged commit b303cd4 into master Jul 21, 2024
4 checks passed
@ben-schwen ben-schwen deleted the rchk-names branch July 21, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants