Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display modifier key warning before unlocking, too #286

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexandru0-dev
Copy link

Original commit at i3lock: i3@deaf8b9

No braking changes

Progression to solving #[201] as this commit DOES NOT have any braking changes

Description

  • Allows to know if the keyboard modifiers are on before checking for the password.
    Before that, you would know if u had CAPS_LOCK and/or others modifiers active only when you pressed enter to check for your password

Release notes

Notes:

  • Display modifier key warning before unlocking, too

Info about mod keys such as Caps Lock is now displayed
during typing, not only on failed attempt.
Original commit at i3lock: i3@deaf8b9

Signed-off-by: Alexandru Nechita <[email protected]>
WIP Migration of the build system from autotools to meson,
following the original i3lock new build system.
Original commits from i3lock:
https://github.com/i3/i3lock/tree/2.14

Signed-off-by: Alexandru Nechita <[email protected]>
@Raymo111 Raymo111 changed the title Display modifier key warning before unlocking, too [WIP] Display modifier key warning before unlocking, too Aug 1, 2023
@Raymo111
Copy link
Owner

Raymo111 commented Aug 1, 2023

Marked this as WIP for now, unmark it and request review when you're done please 🙂

@alexandru0-dev
Copy link
Author

alexandru0-dev commented Aug 1, 2023

yeah for the wip i was going to make another pull request because of breaking changes and bump up in version.
That's why the revert.
I commited into another branch. So they don't interfere

@alexandru0-dev alexandru0-dev changed the title [WIP] Display modifier key warning before unlocking, too Display modifier key warning before unlocking, too Aug 1, 2023
@alexandru0-dev
Copy link
Author

@Raymo111 removed the wip, whenever u are ready

The breaking changes are the in the #287 pull request so it can be already pushed into master.

@alexandru0-dev
Copy link
Author

@Raymo111 any updates?

@Raymo111
Copy link
Owner

Raymo111 commented May 7, 2024

Sorry, missed this for whatever reason. I don't see any changes/diff?

@alexandru0-dev
Copy link
Author

@Raymo111 oh thx for letting me notice it
Apparently I didn't notice that the revert I made also reverted the good commit
This first one:
a5ef3f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants