Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWM Case Lighting (Dayspring/V3D) #115

Open
wants to merge 2 commits into
base: v2.x
Choose a base branch
from
Open

Conversation

AdamV3D
Copy link

@AdamV3D AdamV3D commented Mar 4, 2023

A simple addition for adding PWM case lighting based on the V3D (unofficial RR) white LEDs.

Added pin to all main board where possible.
Some conflicts identified in Manta M8P so pin is left commented.
Some boards without spare PWM pins shown as unsupported.

Added caselight macro with default 0.3 PWM and high PWM rate for smooth motion under LED.

Added commented lighting options to configuration templates.

@HelgeKeck
Copy link
Collaborator

HelgeKeck commented Mar 5, 2023

i assume you are trying to connect a PWM controlled LED since you are connecting it to a FAN port. Would be nice to tell that the user in the comments before he thinks he can connect normal LEDs to it. maybe renaming the pin name to pwm_led_pin, doesnt need to have white in its name, could be another colored LED as well

@AdamV3D
Copy link
Author

AdamV3D commented Mar 5, 2023

Pretty sure any single colour LEDs can be PWM controlled no? The PWM is being done by klipper, not be hardware being connected. It doesn't need to have white in the name i suppose.

@HelgeKeck
Copy link
Collaborator

HelgeKeck commented Mar 5, 2023

i have single neopixel LEDs, not pwm controlled
you dont need to connect these LEDs to a fan port, then you jsut use a normal PIN, or even the RGB header of the board

i mention it only bc i think many people could be confused or believe they can connect any led to that port

@AdamV3D
Copy link
Author

AdamV3D commented Mar 5, 2023

Rgb/neopixel is 3 pin 5v.

White daylight/Daybreak/dayspring and any single colour LEDs I can think of are 2 pin 12/24v. I don't think many people get these two confused do they?

@joaobarros
Copy link
Contributor

Contrary to neopixel/dotstar protocol driven LEDs, driving “ordinary” LEDs via a fan output from the printer’s board should come with a BIG FAT WARNING about the current usage and limit.
People will burn their little board mosfets without knowing why.

@AdamV3D
Copy link
Author

AdamV3D commented Mar 5, 2023

Not sure its contrary to neopixels. Neopixels use 5V so current is high. One of the Ratrig 24V 310mm strip is 5W when driven at 100% (which is excessively bright). 2x 310mm and 2x210 which is full layout for a VC3 500, is like 0.7A Maximum. I've set them up for 30% which would be somewhere around 0.2A.

@HelgeKeck
Copy link
Collaborator

i see a lot users who know nothing about that stuff, i jsut thinnk this should be easier to understand

@AdamV3D
Copy link
Author

AdamV3D commented Mar 7, 2023

@HelgeKeck and @joaobarros, what specifically do you think should be changed?

@miklschmidt
Copy link
Member

miklschmidt commented Mar 15, 2023

Hmmm..

I don't like that these are connected to the fan ports. Some boards have 1A peak fan mosfets, some have less. This is an easy way to blow those. I would use a spare heater, but that complicates things a lot as there most likely will be better use cases for those in the future (IDEX / Toolchangers). I'm not entirely sure how we do this. I'm not entirely sure it's necessary either. It's similar to the filament sensor thing. The goal of RatOS is to make the klipper experience more user friendly, it's not to micromanage every single bit of configuration a user may have to do, hopefully it'll encourage people to learn the configuration at a minimum, and setting up LEDs is one of those easy starter things. Teach a man to fish and what not.

I will have to think about this a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants