Merge pull request #58 from VanFossen/main

fixed warning with useEffect
RastonLab · Jun 27, 2022 · 5ded1dc · 5ded1dc
2 parents 8fdfb25 + 8f2e41c
commit 5ded1dc
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/src/components/Spectrum.jsx b/src/components/Spectrum.jsx
@@ -4,11 +4,14 @@ import "../style/VirtualHendiInterface.css";
 import { saveAs } from "file-saver";
 
 function Spectrum({ data }) {
-  const chartRef = React.createRef();
-  let d = undefined;
+  useEffect(() => {
+    if (data) {
+      generateSpectrum();
+    }
+  });
 
   const generateSpectrum = () => {
-    return new Dygraph(chartRef.current, data, {
+    return new Dygraph(document.getElementById("spectrum"), data, {
       animatedZooms: true,
       xlabel: "Wavelength (cm<sup>-1</sup>)",
       ylabel: "Intensity",
@@ -18,18 +21,14 @@ function Spectrum({ data }) {
     });
   };
 
-  useEffect(() => {
-    d = generateSpectrum();
-  }, []);
-
   const downloadSpectrum = () => {
     const blob = new Blob([data], { type: "text/plain;charset=utf-8" });
     saveAs(blob, "spectrum.csv");
   };
 
   return (
     <div>
-      <div id="spectrum" ref={chartRef} />
+      <div id="spectrum" />
       <button onClick={downloadSpectrum}>Download Spectrum</button>
     </div>
   );