Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Full Retrieval Intent Name #12998

Merged
merged 6 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions rasa/core/processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@
ENTITIES,
INTENT,
INTENT_NAME_KEY,
INTENT_RESPONSE_KEY,
PREDICTED_CONFIDENCE_KEY,
FULL_RETRIEVAL_INTENT_NAME_KEY,
RESPONSE_SELECTOR,
RESPONSE,
TEXT,
)
from rasa.utils.endpoints import EndpointConfig
Expand Down Expand Up @@ -721,6 +725,7 @@ async def parse_message(
message, tracker, only_output_properties
)

self._update_full_retrieval_intent(parse_data)
structlogger.debug(
"processor.message.parse",
parse_data_text=copy.deepcopy(parse_data["text"]),
Expand All @@ -732,6 +737,23 @@ async def parse_message(

return parse_data

def _update_full_retrieval_intent(self, parse_data: Dict[Text, Any]) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a processor unit test for this case please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just added it in the commit acf376b

"""Update the parse data with the full retrieval intent.

Args:
parse_data: Message parse data to update.
"""
intent_name = parse_data.get(INTENT, {}).get(INTENT_NAME_KEY)
response_selector = parse_data.get(RESPONSE_SELECTOR, {})
all_retrieval_intents = response_selector.get("all_retrieval_intents", [])
if intent_name and intent_name in all_retrieval_intents:
retrieval_intent = (
response_selector.get(intent_name, {})
.get(RESPONSE, {})
.get(INTENT_RESPONSE_KEY)
)
parse_data[INTENT][FULL_RETRIEVAL_INTENT_NAME_KEY] = retrieval_intent

def _parse_message_with_graph(
self,
message: UserMessage,
Expand Down
64 changes: 64 additions & 0 deletions tests/core/test_processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@
IS_EXTERNAL,
SESSION_START_METADATA_SLOT,
)
from rasa.shared.nlu.constants import (
INTENT,
INTENT_NAME_KEY,

Check failure on line 89 in tests/core/test_processor.py

View workflow job for this annotation

GitHub Actions / Code Quality

F811 Redefinition of unused `INTENT_NAME_KEY` from line 73
FULL_RETRIEVAL_INTENT_NAME_KEY,
)

import logging

Expand Down Expand Up @@ -1928,3 +1933,62 @@
await processor.run_anonymization_pipeline(tracker)

event_diff.assert_called_once()


async def test_update_full_retrieval_intent(
default_processor: MessageProcessor,
) -> None:
parse_data = {
"text": "I like sunny days in berlin",
"intent": {"name": "chitchat", "confidence": 0.9},
"entities": [],
"response_selector": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is a duplicate curly brace or meant to be a list of dicts instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was indeed a duplicate curly brace, I missed it when I copied the response_selector dictionary from an example bot

{
"all_retrieval_intents": ["faq", "chitchat"],
"faq": {
"response": {
"responses": [{"text": "Our return policy lasts 30 days."}],
"confidence": 1.0,
"intent_response_key": "faq/what_is_return_policy",
"utter_action": "utter_faq/what_is_return_policy",
},
"ranking": [
{
"confidence": 1.0,
"intent_response_key": "faq/what_is_return_policy",
},
{
"confidence": 2.3378809862799945e-19,
"intent_response_key": "faq/how_can_i_track_my_order",
},
],
},
"chitchat": {
"response": {
"responses": [
{
"text": "I am not sure of the whole week but I can see the sun is out today."

Check failure on line 1970 in tests/core/test_processor.py

View workflow job for this annotation

GitHub Actions / Code Quality

E501 Line too long (109 > 88 characters)
},
],
"confidence": 1.0,
"intent_response_key": "chitchat/ask_weather",
"utter_action": "utter_chitchat/ask_weather",
},
"ranking": [
{
"confidence": 1.0,
"intent_response_key": "chitchat/ask_weather",
},
{"confidence": 0.0, "intent_response_key": "chitchat/ask_name"},
],
},
}
},
}

default_processor._update_full_retrieval_intent(parse_data)

assert parse_data[INTENT][INTENT_NAME_KEY] == "chitchat"
# assert that parse_data["intent"] has a key called response
assert FULL_RETRIEVAL_INTENT_NAME_KEY in parse_data[INTENT]
assert parse_data[INTENT][FULL_RETRIEVAL_INTENT_NAME_KEY] == "chitchat/ask_weather"
Loading