-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Full Retrieval Intent Name #12998
Changes from 4 commits
70f397c
3b56c64
3dcbadb
acf376b
58dc8fb
c423d68
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,11 @@ | |
IS_EXTERNAL, | ||
SESSION_START_METADATA_SLOT, | ||
) | ||
from rasa.shared.nlu.constants import ( | ||
INTENT, | ||
INTENT_NAME_KEY, | ||
FULL_RETRIEVAL_INTENT_NAME_KEY, | ||
) | ||
|
||
import logging | ||
|
||
|
@@ -1928,3 +1933,62 @@ | |
await processor.run_anonymization_pipeline(tracker) | ||
|
||
event_diff.assert_called_once() | ||
|
||
|
||
async def test_update_full_retrieval_intent( | ||
default_processor: MessageProcessor, | ||
) -> None: | ||
parse_data = { | ||
"text": "I like sunny days in berlin", | ||
"intent": {"name": "chitchat", "confidence": 0.9}, | ||
"entities": [], | ||
"response_selector": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is a duplicate curly brace or meant to be a list of dicts instead? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was indeed a duplicate curly brace, I missed it when I copied the response_selector dictionary from an example bot |
||
{ | ||
"all_retrieval_intents": ["faq", "chitchat"], | ||
"faq": { | ||
"response": { | ||
"responses": [{"text": "Our return policy lasts 30 days."}], | ||
"confidence": 1.0, | ||
"intent_response_key": "faq/what_is_return_policy", | ||
"utter_action": "utter_faq/what_is_return_policy", | ||
}, | ||
"ranking": [ | ||
{ | ||
"confidence": 1.0, | ||
"intent_response_key": "faq/what_is_return_policy", | ||
}, | ||
{ | ||
"confidence": 2.3378809862799945e-19, | ||
"intent_response_key": "faq/how_can_i_track_my_order", | ||
}, | ||
], | ||
}, | ||
"chitchat": { | ||
"response": { | ||
"responses": [ | ||
{ | ||
"text": "I am not sure of the whole week but I can see the sun is out today." | ||
}, | ||
], | ||
"confidence": 1.0, | ||
"intent_response_key": "chitchat/ask_weather", | ||
"utter_action": "utter_chitchat/ask_weather", | ||
}, | ||
"ranking": [ | ||
{ | ||
"confidence": 1.0, | ||
"intent_response_key": "chitchat/ask_weather", | ||
}, | ||
{"confidence": 0.0, "intent_response_key": "chitchat/ask_name"}, | ||
], | ||
}, | ||
} | ||
}, | ||
} | ||
|
||
default_processor._update_full_retrieval_intent(parse_data) | ||
|
||
assert parse_data[INTENT][INTENT_NAME_KEY] == "chitchat" | ||
# assert that parse_data["intent"] has a key called response | ||
assert FULL_RETRIEVAL_INTENT_NAME_KEY in parse_data[INTENT] | ||
assert parse_data[INTENT][FULL_RETRIEVAL_INTENT_NAME_KEY] == "chitchat/ask_weather" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a processor unit test for this case please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, just added it in the commit acf376b