Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generator test folder name #12925

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix generator test folder name #12925

merged 2 commits into from
Oct 19, 2023

Conversation

djcowley
Copy link
Contributor

@djcowley djcowley commented Oct 18, 2023 •
edited
Loading

Proposed changes:

  • rename cdu test folder to dialogue_understanding for generator tests.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@djcowley djcowley requested review from a team as code owners October 18, 2023 11:08
@djcowley djcowley requested review from rasa-aadlv and removed request for a team October 18, 2023 11:08
@djcowley djcowley changed the base branch from main to dm2 October 18, 2023 11:09
@djcowley djcowley requested review from varunshankar and removed request for rasa-aadlv October 18, 2023 11:10
@djcowley djcowley merged commit 69fef21 into dm2 Oct 19, 2023
99 checks passed
@djcowley djcowley deleted the fix-generator-test-folder-name branch October 19, 2023 06:53
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 53 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunshankar varunshankar varunshankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djcowley @varunshankar