Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset slot value for set_slots once flow ends #12918

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Oct 13, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review October 13, 2023 16:39
@ancalita ancalita requested a review from a team as a code owner October 13, 2023 16:39
@ancalita ancalita requested review from twerkmeister, a team and vcidst and removed request for a team October 13, 2023 16:40
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the additional loop

…tting-slot-value-once-flow-ends-for-set-slots
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 54 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ancalita ancalita merged commit 9ae3440 into dm2 Oct 20, 2023
101 checks passed
@ancalita ancalita deleted the ATO-1626-change-default-behaviour-around-resetting-slot-value-once-flow-ends-for-set-slots branch October 20, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants