Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pypric configuration from docs #12908

Closed
wants to merge 1 commit into from
Closed

remove pypric configuration from docs #12908

wants to merge 1 commit into from

Conversation

souvikg10
Copy link
Contributor

Proposed changes:

  • This removes the pypric configuration which is not needed for installing rasa-plus

Status (please check what you already did):

  • added some tests for the functionality
  • [x ] updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12908--rasahq-docs-rasa-v2.netlify.app/docs/rasa

m-vdb
m-vdb reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was supposed to do those changes. Would you mind coordinating with @trammell ? 🙏🏻

@souvikg10
Copy link
Contributor Author

yes, i see. some suggestion are already there. i will talk with @trammell. I can close this PR

@souvikg10 souvikg10 closed this Oct 10, 2023
@m-vdb m-vdb deleted the remove-pypric branch October 10, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb left review comments

@rasa-jmac rasa-jmac Awaiting requested review from rasa-jmac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@souvikg10 @m-vdb