Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: python package upgrade #12903

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Housekeeping: python package upgrade #12903

merged 2 commits into from
Oct 10, 2023

Conversation

varunshankar
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@varunshankar varunshankar self-assigned this Oct 9, 2023
@varunshankar varunshankar requested review from twerkmeister, djcowley and a team October 9, 2023 08:27
djcowley
djcowley requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@djcowley djcowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the attrs upgrade now contradicts the line in the pyproject.toml

rasa/pyproject.toml

Line 94 in 116343c

attrs = ">=19.3,<22.2"

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@varunshankar varunshankar enabled auto-merge (squash) October 9, 2023 14:09
@varunshankar varunshankar merged commit 264fa14 into main Oct 10, 2023
101 checks passed
@varunshankar varunshankar deleted the 1006-housekeeping branch October 10, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djcowley djcowley djcowley approved these changes

@twerkmeister twerkmeister Awaiting requested review from twerkmeister

Assignees

@varunshankar varunshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunshankar @djcowley