Eng 496 intentless changes #12900
Eng 496 intentless changes #12900
Conversation
…flow stack frames
There was a problem hiding this comment.
added the new actions and the previously missing ActionCleanStack to the default action list
There was a problem hiding this comment.
Added the action that puts a ChitchatStackFrame on the stack - which in turn allows the intentless policy to act. So this action needs to be triggered by the chitchat flow if one wants to use the intentless policy for chitchat
There was a problem hiding this comment.
Added the action that puts a SearchStackFrame on the stack - which in turn allows the doc search policy to act. So this action needs to be triggered by the search flow if one wants to use the doc search policy for knowledge based questions
There was a problem hiding this comment.
Instead of directly putting a ChitchatStackFrame (which allows the intentless policy to act) we put a ChitchatPatternFlowStackFrame on the stack which executes pattern_chitchat. pattern_chitchat can then be configured to use a free generation or execute action_trigger_chitchat (which then allows the intentless policy to act).
There was a problem hiding this comment.
same as above for the chitchat
There was a problem hiding this comment.
PatternFlowStackFrame for the pattern_chitchat. Was missing so far despite the pattern being there
There was a problem hiding this comment.
- adjusted all patterns to use the new flow syntax
- added
pattern_searchwith a default utterance when not connected to a knowledge base (e.g. doc search being not present)
There was a problem hiding this comment.
added flow stack frame for pattern_search
There was a problem hiding this comment.
- added property to retrieve all utterances used in a flow - relevant for validation and also for intentless in rasa-pro
- added a method for deriving default names for flows from their id instead of going with empty names
There was a problem hiding this comment.
I think this might still fail the new json schema validation, I've asked Uros yesterday to make flow name as required property. Best to discuss with him if he should revert that?
There was a problem hiding this comment.
Moved helper method that was originally in tests here to also be able to use it in rasa-pro tests for my PR on intentless policy changes
There was a problem hiding this comment.
Removed utterance collection logic here from the validation as it's present in reusable form as part of the flow objects
There was a problem hiding this comment.
- Adjusted a test to be compatible with actions being added without failing
- Added a test that checks that default action names and default actions are in sync
There was a problem hiding this comment.
Added a test that the validator catches empty flow names
There was a problem hiding this comment.
Moved this method to be reusable by rasa pro
There was a problem hiding this comment.
added action names for new actions
|
Kudos, SonarCloud Quality Gate passed!
|
| The created `DialogueStackFrame`. | ||
| """ | ||
| return ChitchatPatternFlowStackFrame( | ||
| frame_id=data["frame_id"], |
There was a problem hiding this comment.
I suppose this is a parent class attribute that gets inherited?
There was a problem hiding this comment.
I think this might still fail the new json schema validation, I've asked Uros yesterday to make flow name as required property. Best to discuss with him if he should revert that?
* retrieving all utterances from flows with new attribute * Added trigger actions for search and chitchat * added search pattern * adjusted patterns for new yaml format * added test for default action + name consistency * fixed default flows * setting default flow name, if there is none
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)