Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont run roberto workflow on forks #12898

Merged
merged 2 commits into from
Oct 6, 2023
Merged

dont run roberto workflow on forks #12898

merged 2 commits into from
Oct 6, 2023

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Oct 6, 2023 •
edited
Loading

Proposed changes:
Fixes https://rasahq.atlassian.net/browse/ATO-1627

  • Don't run roberto workflow on pull requests coming from forks

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb requested a review from a team as a code owner October 6, 2023 07:43
@m-vdb m-vdb requested review from miraai, ancalita and a team and removed request for a team October 6, 2023 07:43
ancalita
ancalita reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Could we also update the Slack webhook so we get notified when this workflow fails? That was the 2nd issue in the ticket 🙏🏻

@m-vdb m-vdb requested a review from ancalita October 6, 2023 08:41
@m-vdb m-vdb merged commit 7f5cbf0 into 3.6.x Oct 6, 2023
98 of 99 checks passed
@m-vdb m-vdb deleted the ATO-1627-fix-roberto-workflow branch October 6, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

@miraai miraai Awaiting requested review from miraai miraai is a code owner automatically assigned from RasaHQ/infrastructure-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-vdb @ancalita