Merge 3.6.x into main #12897
Merged
Merge 3.6.x into main #12897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prepared release of version 3.6.10
In OSS-413 a user reports that since Rasa 3.1 the interactive training dialogue suggests malformed/shortened intent names, e.g.: - a - b - c This is due to a bug in the parsing of intent names which assumes that every intent is a dictionary (which it is ONLY when a property such as `use_entities` is set). While OSS-413 states that this is solely cosmetic it is an actual bug that caused severe problems that cost several hours to debug: When using the regex matcher it is checked whether the parsed intent is in the domain or not. When it is not, it will fail and attempt to revert the user utterance. The user utterance is then written to the tracker but `SlotSet` events are not repeated - therefore any form validator will fail for inexplicable reasons. This also means that there is a bug in the `_correct_wrong_nlu` for not copying enough or re-starting the `ActionExtractSlots` action which is not addressed here.
Since the main problem of bug OSS-413 is that intents with attributes are not retrieved well the test was implemented to use domains with and without intent definitions using attributes.
Fix OSS-413: Proper intents in interactive training
* cache session property of endpoint config * fix session is closed runtime error * ref: remove async manager for session * revert cached_property, implement sanic listener + lru cache * trigger CI * pin ddtrace in CI workflow * separate pip install commands for ddtrace per OS * update flaky tests jobs; remove poetry command * address review suggestions * make failing unit test async * add changelog, add closing of connection pools to after_server_stop listener --------- Co-authored-by: souvik ghosh <[email protected]>
prepared release of version 3.6.11
* fix no space left on device in github job * add dockerignore to /docker subdir * remove AGENT_TOOLSDIRECTORY * add -f to docker image prune, add check disk space step after docker build
ancalita
approved these changes
Oct 5, 2023
|
🚀 A preview of the docs have been deployed at the following URL: https://12897--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 This pull request was created automatically to merge a release branch back into the `main` branch.
The changes you see here should have already been reviewed by someone, and shouldn't need an extra
review. Nonetheless, if you notice something that needs to be addressed, please reach out to the person
responsible for the original changes. In case additional changes need to be made, they need to target the release branch
(not this pull request nor `main`).
🛺 This PR should be merged automatically once it has been approved. If it doesn't happen: