Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eng 472 component wrap up llm command generator #12873

Merged
merged 18 commits into from
Oct 20, 2023
Merged

Eng 472 component wrap up llm command generator #12873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9c69718
chore: renamed cdu folder in tests as dialogue_understanding.
djcowley Sep 20, 2023
25ce5fe
added render_template test.
djcowley Sep 20, 2023
4c82cbe
added is extractable tests and tidy up.
djcowley Sep 24, 2023
23329f7
fixed generate commnands tests and tidy up doc strings.
djcowley Sep 26, 2023
97565f8
fixed collect information flow steps and applied black formatter.
djcowley Sep 26, 2023
f4b67fe
fixed missed long line in in tests.
djcowley Sep 26, 2023
6fb3dd8
fixed single trailing whitespace.
djcowley Sep 26, 2023
a088531
fixed use of pipe operator.
djcowley Sep 26, 2023
5cb9634
chore: fix unit tests after rebase.
djcowley Oct 4, 2023
8194f0b
chore: fix collect_information.
djcowley Oct 5, 2023
ff6de9f
chore: responded to review comments. adding FlowList.user_flows, upda…
djcowley Oct 8, 2023
5221173
chore: added testing for FlowsList.user_flows including __eq__ method…
djcowley Oct 9, 2023
6b13c0a
chore: addressed comments on tests.
djcowley Oct 10, 2023
4b4a29c
Merge branch 'dm2' into ENG-472-Component-Wrap-up-LLMCommandGenerator
djcowley Oct 13, 2023
6eca72a
chore: fixed type hints for python 3.8.
djcowley Oct 16, 2023
7ec98a2
chore: updated schema for flow in test.
djcowley Oct 16, 2023
09a56a1
chore: updated render prompt test to test line by line.
djcowley Oct 18, 2023
2981e0d
Merge branch 'dm2' into ENG-472-Component-Wrap-up-LLMCommandGenerator
djcowley Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rasa/dialogue_understanding/commands/start_flow_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def run_command_on_tracker(
"command_executor.skip_command.already_started_flow", command=self
)
return []
elif self.flow not in all_flows.non_pattern_flows():
elif self.flow not in all_flows.user_flow_ids:
structlogger.debug(
"command_executor.skip_command.start_invalid_flow_id", command=self
)
Expand Down
4 changes: 2 additions & 2 deletions rasa/dialogue_understanding/generator/command_prompt_template.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ Here is what happened previously in the conversation:

===
{% if current_flow != None %}
You are currently in the flow "{{ current_flow }}", which {{ current_flow.description }}
You have just asked the user for the slot "{{ collect }}"{% if collect_description %} ({{ collect_description }}){% endif %}.
You are currently in the flow "{{ current_flow }}".
You have just asked the user for the slot "{{ current_slot }}"{% if current_slot_description %} ({{ current_slot_description }}){% endif %}.

{% if flow_slots|length > 0 %}
Here are the slots of the currently active flow:
Expand Down
Loading
Loading