Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved existing examples into subfolder #12860

Merged
merged 18 commits into from
Oct 18, 2023
Merged

moved existing examples into subfolder #12860

merged 18 commits into from
Oct 18, 2023

Conversation

amn41
Copy link
Contributor

@amn41 amn41 commented Sep 25, 2023 •
edited
Loading

Proposed changes:

  • addresses ENG-566
  • one of the docs checks is currently failing, but that's a catch-22 because the URL won't exist until this is merged. But actually it won't pass until we merge this into main. Do we want to switch this to a temp url?

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@amn41 amn41 mentioned this pull request Sep 27, 2023
Closed
4 tasks
@amn41 amn41 requested a review from m-vdb September 28, 2023 07:44
@amn41 amn41 marked this pull request as ready for review September 28, 2023 07:44
@amn41 amn41 requested a review from a team as a code owner September 28, 2023 07:44
@amn41 amn41 removed the request for review from a team September 28, 2023 07:45
m-vdb
m-vdb reviewed Sep 28, 2023
View reviewed changes
examples/money_transfer/data/flows.yml Outdated Show resolved Hide resolved
docs/docs/domain.mdx Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12860--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@m-vdb m-vdb merged commit 7dc7a33 into dm2 Oct 18, 2023
97 of 99 checks passed
@m-vdb m-vdb deleted the move_examples branch October 18, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amn41 @m-vdb