Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutorial improvements #12845

Merged
merged 13 commits into from
Oct 21, 2023
Merged

tutorial improvements #12845

merged 13 commits into from
Oct 21, 2023

Conversation

amn41
Copy link
Contributor

@amn41 amn41 commented Sep 22, 2023 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@amn41 amn41 changed the title add action labels, switch bot to assistant tutorial improvements Sep 22, 2023
@amn41
Copy link
Contributor Author

amn41 commented Oct 19, 2023 •
edited
Loading

@dakshvar22 @m-vdb maybe one of you can review. Also related is this PR that needs to be merged so the domain.yml in the template matches what you see in the docs (no slot mappings, added description to amount step in flow) #12928

currently build is failing bc the test-docs step isn't using the latest dm2 branch (I think), complains about the lack of slot mapping definitions

m-vdb
m-vdb approved these changes Oct 20, 2023
View reviewed changes
docs/docs/tutorial.mdx Outdated Show resolved Hide resolved
@amn41 amn41 marked this pull request as ready for review October 20, 2023 13:30
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12845--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@amn41 amn41 merged commit 50423f6 into docs-dm2 Oct 21, 2023
100 of 101 checks passed
@amn41 amn41 deleted the docs-dm2-improve-tutorial branch October 21, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

@dakshvar22 dakshvar22 Awaiting requested review from dakshvar22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amn41 @m-vdb