Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

described basic working of llm flows classifier #12529

Merged
merged 10 commits into from
Jun 20, 2023
Merged

Conversation

twerkmeister
Copy link
Contributor

Proposed changes:

  • described basic working of llmflowclassifier

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@twerkmeister twerkmeister requested a review from tmbo June 19, 2023 17:27
@tmbo tmbo requested a review from m-vdb June 19, 2023 19:52
@@ -11,3 +11,145 @@ import RasaDiscoveryBanner from "@theme/RasaDiscoveryBanner";

<RasaDiscoveryBanner/>

# LLMFlowClassifier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do need a better name, but not today. i find this a bit confusing

docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
docs/docs/llms/llm-flow-classifier.mdx Outdated Show resolved Hide resolved
which would then be turned into the `transfer_money` intent as well as two entities.

Certain asks by the user and responses by the LLM are currently deemed as too complex
and classified as such based on the composition of the action list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we explain a bit more about why we needed to do this? and can you explain what happens when something is classified as "too complex": is the result that the output of the classifier is ignored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, users can technically come up with arbitrarily complex commands like "start 1000000 money transfers" but on a more benign site they might just try to do a lot of things at once "50$ to James. And then please tell me how much money I still have left, and my recent transactions". For now, we just say, let's take it step by step. Doesn't mean we can't allow for more complexity later. We might actually be able it, but I think it's also good if there's some limit and we communicate that instead of attempting and failing.

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12529--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@m-vdb m-vdb merged commit e9e50d3 into dm2 Jun 20, 2023
@m-vdb m-vdb deleted the ENG-357-llmflowclassifier branch June 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants